Conversation
…ucture - Split set_nodes_attrs/set_relationships_attrs into new/existing variants for optimized fast-path (new entities skip fjall lookups) - Add effects buffer serialization (build_effects_buffer) for replication - Add schema baseline tracking in Pending for incremental schema effects - Wire effects buffer building into CommitOp (before commit) - Fix properties_set counts in test_effects.py for new behavior
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 15 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit() doesn't clear pending state — clear() does that separately. So effects buffer can safely be built after a successful commit.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 82.48% 82.32% -0.17%
==========================================
Files 109 110 +1
Lines 29580 30078 +498
==========================================
+ Hits 24400 24762 +362
- Misses 5180 5316 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary
set_nodes_attrs/set_relationships_attrsintonew_*/existing_*variants for optimized paths (new entities skip fjall lookups)build_effects_buffer()for binary effects serialization (replication)Pendingfor incremental schema effectsCommitOp(build before commit, clear after)properties_setcounts intest_effects.pyPart of splitting #359 into smaller reviewable PRs.
Test plan
cargo test -p graphpassespytest tests/test_e2e.py -vvpassesTEST=tests/flow/test_effects.py ./flow.sh